🐛 Source Twilio: Lookback_window config #17478

artem1205 · 2022-09-30T20:01:05Z

What

Resolving #237

How

Set both minimum and maximum value for lookback_window
set lookback_window to 0 if it was not specified by user

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

artem1205 · 2022-09-30T20:01:20Z

/test connector=connectors/source-twilio

🕑 connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/3161351391
✅ connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/3161351391
Python tests coverage:

Name                        Stmts   Miss  Cover
-----------------------------------------------
source_twilio/auth.py           8      0   100%
source_twilio/__init__.py       2      0   100%
source_twilio/source.py        28      2    93%
source_twilio/streams.py      241     24    90%
-----------------------------------------------
TOTAL                         279     26    91%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       152     26    83%   21-23, 29-31, 36-43, 48-61, 239, 250-258
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-67, 70-72, 75-77, 80-82, 85-87, 90-92, 95-113, 147-149
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1358    466    66%

Build Passed

Test summary info:

All Passed

artem1205 · 2022-09-30T20:49:59Z

/publish connector=connectors/source-twilio

🕑 Publishing the following connectors:
connectors/source-twilio
https://github.com/airbytehq/airbyte/actions/runs/3161600271

Connector	Did it publish?	Were definitions generated?
connectors/source-twilio	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

artem1205 · 2022-09-30T21:20:55Z

/publish connector=connectors/source-twilio

🕑 Publishing the following connectors:
connectors/source-twilio
https://github.com/airbytehq/airbyte/actions/runs/3161754728

Connector	Did it publish?	Were definitions generated?
connectors/source-twilio	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

…ations * master: (75 commits) source-sentry: migrate to per-stream states (#17466) Greg/clickhouse polishing (#17483) upgrade debezium version to 1.9.6 (#17459) 🐛 Source Twilio: Lookback_window config (#17478) hide S3 source connector from catalog (#17472) 🪟 Migrate styles for Connection-related Components (#17339) Added new title (#17480) Refactor & convert `PageTitle` to SCSS (#17139) updated releaseStage for zendesk-talk (#17477) [low-code] Apply log level to stream loggers (#17284) 🐛 Source Salesforce: filter out objects not supported by the Bulk API (#17453) Source Marketo: certify GA (#17445) Update greenhouse paginator (#17429) Add some services start validation to acceptance_tests.sh (#17425) 📖 Removes $ from terminal commands to allow direct copying. (#17467) migrate source GA connectors to per-stream states (2) (#17410) Source Klaviyo: bump CDK dependency (#17422) Source Pinterest: change releaseStage to GA (#17045) Source Pinterest: Set start_date dynamically based on API restrictions for lookup (#17387) updated releaseStage to generally_available (#17374) ...

* master: source-sentry: migrate to per-stream states (#17466) Greg/clickhouse polishing (#17483) upgrade debezium version to 1.9.6 (#17459) 🐛 Source Twilio: Lookback_window config (#17478) hide S3 source connector from catalog (#17472) 🪟 Migrate styles for Connection-related Components (#17339) Added new title (#17480) Refactor & convert `PageTitle` to SCSS (#17139) updated releaseStage for zendesk-talk (#17477) [low-code] Apply log level to stream loggers (#17284) 🐛 Source Salesforce: filter out objects not supported by the Bulk API (#17453) Source Marketo: certify GA (#17445) Update greenhouse paginator (#17429) Add some services start validation to acceptance_tests.sh (#17425) 📖 Removes $ from terminal commands to allow direct copying. (#17467)

* 🐛 Source Twilio: Lookback_window config * 🐛 Source Twilio: update docs * 🐛 Source Twilio: update specs * 🐛 Source Twilio: test fix backward compatibility * auto-bump connector version [ci skip] Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

🐛 Source Twilio: Lookback_window config

f0b8514

github-actions bot added the area/connectors Connector related issues label Sep 30, 2022

octavia-squidington-iv added the connectors/source/twilio label Sep 30, 2022

🐛 Source Twilio: update docs

d34044a

github-actions bot added the area/documentation Improvements or additions to documentation label Sep 30, 2022

artem1205 requested review from arsenlosenko and grubberr September 30, 2022 20:21

🐛 Source Twilio: update specs

72e4711

lazebnyi self-requested a review September 30, 2022 20:48

lazebnyi approved these changes Sep 30, 2022

View reviewed changes

🐛 Source Twilio: test fix backward compatibility

cebab8a

auto-bump connector version [ci skip]

35a4f9e

artem1205 merged commit aaa94f1 into master Sep 30, 2022

artem1205 deleted the 16658-source-twilio-config-2 branch September 30, 2022 23:07

octavia-squidington-iii mentioned this pull request Oct 5, 2022

Bump Airbyte version from 0.40.10 to 0.40.11 #17610

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Source Twilio: Lookback_window config #17478

🐛 Source Twilio: Lookback_window config #17478

artem1205 commented Sep 30, 2022

artem1205 commented Sep 30, 2022 •

edited by github-actions bot

Loading

artem1205 commented Sep 30, 2022 •

edited by github-actions bot

Loading

artem1205 commented Sep 30, 2022 •

edited by github-actions bot

Loading

🐛 Source Twilio: Lookback_window config #17478

🐛 Source Twilio: Lookback_window config #17478

Conversation

artem1205 commented Sep 30, 2022

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Tests

artem1205 commented Sep 30, 2022 • edited by github-actions bot Loading

Build Passed

artem1205 commented Sep 30, 2022 • edited by github-actions bot Loading

artem1205 commented Sep 30, 2022 • edited by github-actions bot Loading

artem1205 commented Sep 30, 2022 •

edited by github-actions bot

Loading

artem1205 commented Sep 30, 2022 •

edited by github-actions bot

Loading

artem1205 commented Sep 30, 2022 •

edited by github-actions bot

Loading